crates/biome_grit_patterns/src/grit_built_in_functions.rs (1)

580-588: Make capitalise Unicode-aware (not just ASCII)

to_ascii_uppercase won’t handle non-ASCII letters (e.g. é, ß). Prefer Unicode uppercasing of the first char; keep the borrowed fast-path:

-fn capitalize(s: &str) -> Cow<'_, str> {
-    if let Some(first_char) = s.chars().next()
-        && !first_char.is_uppercase()
-    {
-        let rest = &s[first_char.len_utf8()..];
-        return Cow::Owned(first_char.to_ascii_uppercase().to_string() + rest);
-    }
-    Cow::Borrowed(s)
-}
+fn capitalize(s: &str) -> Cow<'_, str> {
+    let mut chars = s.chars();
+    let Some(first) = chars.next() else {
+        return Cow::Borrowed(s);
+    };
+    if first.is_uppercase() {
+        return Cow::Borrowed(s);
+    }
+    let mut owned = first.to_uppercase().to_string(); // may be multi-char
+    owned.push_str(chars.as_str());
+    Cow::Owned(owned)
+}

Consider adding tests for non-ASCII input to lock behaviour.

Would you like me to add a small test matrix (e.g. "éclair"→"Éclair", "straße"→"Straße", "ß..."→"SS..." depending on desired mapping)?

crates/biome_string_case/src/lib.rs (2)

648-648: Explicit lifetime on Cow clarifies borrowing; no behaviour change

Good call switching to Cow<'_, Self>; this matches rustc/clippy expectations on elided lifetimes in type paths and keeps the API semantics intact.

Tiny nit in the doc just above: “this functions returns” → “this function returns”.

---

661-661: Same here: lifetime made explicit on Cow

Consistent with the previous trait; this silences the elided-lifetime lint and is semantically equivalent to the former signature.

Doc nit: “this functions returns” → “this function returns”.

rust-toolchain.toml (1)

5-5: Toolchain bump looks good.

Channel pinned to 1.89.0 is consistent with CI updates. Ensure you run just f to reformat TOML as per repo guidelines.

.github/workflows/release.yml (1)

185-185: Pinned Rust 1.89.0-bullseye digest looks consistent.

GNU builds keep bullseye for older glibc—good call. Consider adding a brief comment next to the image pin on how to refresh digests, to keep future bumps smooth.

crates/biome_grit_patterns/src/grit_node.rs (1)

75-75: Optional: avoid allocation if TokenText can be borrowed

If TokenText exposes as_str() (or Deref<Target = str>), you can return a borrowed slice and skip allocating:

• Use Ok(Cow::Borrowed(self.0.text_trimmed().as_str())).

If not available, feel free to ignore.

crates/biome_service/src/settings.rs (1)

198-216: Cow lifetimes tied to &self are appropriate here

• The explicit '_' makes it clear when we return borrowed config vs materialise an owned copy via to_mut(). The merge paths for rules/domains/actions remain correct.
• get_plugins_for_path/as_all_plugins correctly switch to Owned only when needed and extend without altering the base config.

If you fancy a micro-optimisation later: consider deduping plugins when multiple overrides add the same entries. Not urgent for this PR.

Also applies to: 220-238, 242-259, 263-272, 276-290

crates/biome_grit_patterns/src/grit_target_node.rs (1)

381-383: Prefer disambiguation to avoid method-name shadowing confusion

Inside the trait impl, calling self.text() resolves to the inherent method here, but it’s easy to misread as recursive. Consider fully qualifying the inherent call.

-        Ok(Cow::Borrowed(self.text()))
+        Ok(Cow::Borrowed(GritTargetNode::text(self)))

crates/biome_grit_formatter/src/verbatim.rs (1)

154-154: Quick sanity check: naming looks off in this crate

This is grit, but the type is FormatGraphqlVerbatimNode and functions are “graphql”/“bogus”/“suppressed”. Intentional cross-crate reuse, or leftover naming?

crates/biome_module_graph/src/js_module_info/module_resolver.rs (1)

404-409: Cow<'_, TypeData> return is appropriate

Currently always returns Owned, which is fine and explicit. If you ever expose a borrowed variant from ResolvedTypeData, this could avoid allocations, but not required for this PR.