fix(core): resolve aliased imports #7121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b6c0c8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
arendjr
commented
Aug 5, 2025
| "{base_dir}/node_modules/sleep/dist/src/index.d.ts" | ||
| ))) | ||
| ); | ||
| } |
There was a problem hiding this comment.
This test is another bonus. I suspected there was an issue in this area, but there wasn't. At least we have extra coverage now.
WalkthroughThis set of changes addresses the handling of aliased imports in the symbol resolution logic, specifically ensuring that the Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (6)
🧰 Additional context used📓 Path-based instructions (4).changeset/*.md📄 CodeRabbit Inference Engine (CONTRIBUTING.md)
Files:
**/*.{rs,toml}📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
crates/biome_*/**/*📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
**/*.rs📄 CodeRabbit Inference Engine (CONTRIBUTING.md)
Files:
🧠 Learnings (36)📓 Common learnings📚 Learning: the file `packages/@biomejs/biome/configuration_schema.json` is auto-generated and should not be man...Applied to files:
📚 Learning: test rules using quick tests in the appropriate test file (e.g., `biome_js_analyze/tests/quick_test....Applied to files:
📚 Learning: applies to crates/biome_service/src/workspace/watcher.tests.rs : add tests for watcher workspace met...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/*.rs : update the `language` field in `...Applied to files:
📚 Learning: applies to crates/biome_formatter/tests/spec_tests.rs : update the `spec_tests.rs` file to generate ...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/*.rs : each code block in rule document...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/*.rs : when banning certain functions o...Applied to files:
📚 Learning: applies to crates/biome_service/../biome_lsp/src/server.tests.rs : add end-to-end tests for watcher ...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/*.rs : new rules must be placed inside ...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/*.rs : when implementing the `run` func...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/*.rs : if a lint rule is ported from an...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/*.rs : the `declare_lint_rule!` macro m...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/*.rs : rule documentation must start wi...Applied to files:
📚 Learning: run tests using `cargo test` or `just test` for rust crates....Applied to files:
📚 Learning: applies to benches/html_formatter.rs : benchmark for html formatter must be in `benches/html_formatt...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/{no_invalid*,use_valid*}_*.rs : rules t...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/no_unused*_*.rs : rules that report unu...Applied to files:
📚 Learning: applies to crates/biome_js_type_info/../biome_module_graph/src/js_module_info/scoped_resolver.rs : f...Applied to files:
📚 Learning: applies to crates/biome_js_type_info/../biome_module_graph/src/js_module_info/collector.rs : module-...Applied to files:
📚 Learning: applies to crates/biome_js_formatter/**/*.rs : do not attempt to 'fix' the code when formatting ast ...Applied to files:
📚 Learning: applies to crates/biome_js_type_info/src/resolver.rs : implement and maintain the `typeresolver` tra...Applied to files:
📚 Learning: applies to crates/biome_js_formatter/**/*.rs : for tokens that are not mandatory, use the provided h...Applied to files:
📚 Learning: applies to crates/biome_js_formatter/**/*.rs : when formatting ast nodes, if a token is mandatory an...Applied to files:
📚 Learning: applies to crates/biome_js_formatter/**/*.rs : import the `formatnode` trait and implement it for yo...Applied to files:
📚 Learning: applies to crates/biome_parser/crates/biome_*/**/*.rs : use conditional syntax handling to add diagn...Applied to files:
📚 Learning: applies to crates/biome_js_type_info/src/local_inference.rs : local type inference should only creat...Applied to files:
📚 Learning: applies to crates/biome_formatter/tests/{spec_test.rs,spec_tests.rs,language.rs} : inside the `biome...Applied to files:
📚 Learning: applies to crates/biome_formatter/tests/spec_test.rs : implement the `run` function in `spec_test.rs...Applied to files:
📚 Learning: applies to crates/biome_js_type_info/src/type_info.rs : when using `resolvedtypedata`, always use th...Applied to files:
📚 Learning: applies to crates/biome_js_type_info/src/flattening.rs : flattening of type expressions (e.g., reduc...Applied to files:
📚 Learning: applies to crates/biome_js_type_info/src/type_info.rs : avoid circular or recursive data structures ...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_rule_options/lib/*.rs : use boxed slices (`box<[box]>`) i...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/*.rs : avoid unnecessary string allocat...Applied to files:
📚 Learning: applies to crates/biome_js_type_info/src/type_info.rs : the `typedata` enum, defined in `src/type_in...Applied to files:
📚 Learning: applies to crates/biome_js_type_info/src/type_info.rs : use `typedata::unknown` to represent cases w...Applied to files:
🪛 LanguageTool.changeset/aliased-antilopes-acknowledge.md[style] ~5-~5: Would you like to use the Oxford spelling “recognized”? The spelling ‘recognised’ is also correct. (OXFORD_SPELLING_Z_NOT_S) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (25)
🔇 Additional comments (6)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
1 task
CodSpeed Performance ReportMerging #7121 will not alter performanceComparing Summary
Footnotes |
Merged
|
not sure to understand 100% of this, but couldn't that fix #6432 ? |
|
Thanks for pointing out that PR, I had overlooked it. But no, it’s a separate issue. |
This was referenced Aug 10, 2025
1 task
1 task
This was referenced Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed #7111: Imported symbols using aliases are now correctly recognised.
Also squeezed in a tiny optimisation for the resolver, to avoid allocations when someone has
typeRootsin theirtsconfig.json.Test Plan
Test added.