feat(analyze/js): added rule for `@typescript-eslint/consistent-type-definitions` #7053

jakeleventhal · 2025-07-28T13:52:53Z

Summary

Implements https://typescript-eslint.io/rules/consistent-type-definitions/

This resolves #7036

Test Plan

Unit tests

Docs

changeset-bot · 2025-07-28T13:52:57Z

🦋 Changeset detected

Latest commit: 30f7b5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dyc3

Just in case you missed it, there's a separate CONTRIBUTING doc specifically for the analyzer: https://github.com/biomejs/biome/blob/main/crates/biome_analyze/CONTRIBUTING.md

crates/biome_js_analyze/src/lint/style/use_consistent_type_definitions.rs

.changeset/use-consistent-type-definitions.md

ematipico

You must run cargo test, review the snapshots and accept them. https://github.com/biomejs/biome/blob/main/CONTRIBUTING.md#testing

crates/biome_js_analyze/src/lint/style/use_consistent_type_definitions.rs

jakeleventhal · 2025-07-28T17:07:08Z

@dyc3 @ematipico @siketyan addressed all and rebased

dyc3

Please note the CI failures. It doesn't build.

.changeset/use-consistent-type-definitions.md

codspeed-hq · 2025-07-29T15:38:00Z

CodSpeed Performance Report

Merging #7053 will not alter performance

_{Comparing jakeleventhal:typescript-eslint-consistent-type-definitions (6d2dc2b) with main (bb91a11)}

Summary

✅ 128 untouched benchmarks

dyc3

You need to run just gen-all to get all the other things updated

Then accept the snapshots and commit them.

cargo test -p biome_js_analyze
cargo insta accept

crates/biome_js_analyze/tests/specs/nursery/useConsistentTypeDefinitions/invalid.ts

dyc3

LGTM!

…pt-eslint-consistent-type-definitions

ematipico

We should fix the docs of options, and we should add more tests. We should add tests of code with comments around the members and the curly brackets

.changeset/use-consistent-type-definitions.md

crates/biome_js_analyze/src/lint/nursery/use_consistent_type_definitions.rs

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>

…pt-eslint-consistent-type-definitions

ematipico · 2025-08-01T20:44:25Z

@jakeleventhal

We should add tests of code with comments around the members and the curly brackets

This hasn't been addressed. Here's an example

interface/**/ Foo /**/ {/**/
  /**/lorem:/**/ boolean/**/
/**/}

Essentially, we want to test that we don't lose trivia when doing the action.

If you want, we can address this in another. Just let us know

jakeleventhal · 2025-08-01T21:27:47Z

@ematipico I see what you mean. In any case, addressed

ematipico

Awesome work 🫡

.changeset/use-consistent-type-definitions.md

github-actions bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Jul 28, 2025

dyc3 requested changes Jul 28, 2025

View reviewed changes

siketyan reviewed Jul 28, 2025

View reviewed changes

.changeset/use-consistent-type-definitions.md Outdated Show resolved Hide resolved

dyc3 mentioned this pull request Jul 28, 2025

feat(analyze/js): added rule for @typescript-eslint/no-unnecessary-template-expression #7054

Closed

ematipico requested changes Jul 28, 2025

View reviewed changes

jakeleventhal force-pushed the typescript-eslint-consistent-type-definitions branch from c245a51 to 1b82785 Compare July 28, 2025 17:06

jakeleventhal requested review from dyc3, ematipico and siketyan July 28, 2025 17:06

jakeleventhal force-pushed the typescript-eslint-consistent-type-definitions branch from 1b82785 to 5b74c79 Compare July 28, 2025 17:06

dyc3 changed the title ~~Added rule for @typescript-eslint/consistent-type-definitions~~ feat(analyze/js): added rule for @typescript-eslint/consistent-type-definitions Jul 28, 2025

jakeleventhal force-pushed the typescript-eslint-consistent-type-definitions branch from 91d6d42 to e4a69ef Compare July 28, 2025 18:56

dyc3 requested changes Jul 29, 2025

View reviewed changes

.changeset/use-consistent-type-definitions.md Show resolved Hide resolved

jakeleventhal force-pushed the typescript-eslint-consistent-type-definitions branch 2 times, most recently from 12a9436 to d15c802 Compare July 29, 2025 14:36

jakeleventhal requested a review from dyc3 July 29, 2025 14:53

dyc3 requested changes Jul 29, 2025

View reviewed changes

crates/biome_js_analyze/tests/specs/nursery/useConsistentTypeDefinitions/invalid.ts Show resolved Hide resolved

jakeleventhal force-pushed the typescript-eslint-consistent-type-definitions branch from f905e2a to de01e72 Compare July 29, 2025 16:02

github-actions bot added the A-CLI Area: CLI label Jul 29, 2025

jakeleventhal added 4 commits July 30, 2025 09:19

Using consistent type definitions

7e6dc31

Fix build

a24fd2e

Updating rule once more

5e3a68f

Fix

99aec20

jakeleventhal force-pushed the typescript-eslint-consistent-type-definitions branch from de01e72 to 99aec20 Compare July 30, 2025 15:10

jakeleventhal requested a review from dyc3 July 30, 2025 15:30

dyc3 approved these changes Jul 30, 2025

View reviewed changes

jakeleventhal added 2 commits July 30, 2025 16:03

Merge branch 'main' into typescript-eslint-consistent-type-definitions

d619f8d

Merge commit '0cc38f59cd9ddf0fdcd12d6f8cb3642743cc4406' into typescri…

7c7991e

…pt-eslint-consistent-type-definitions

ematipico reviewed Jul 31, 2025

View reviewed changes

.changeset/use-consistent-type-definitions.md Show resolved Hide resolved

crates/biome_js_analyze/src/lint/nursery/use_consistent_type_definitions.rs Show resolved Hide resolved

crates/biome_js_analyze/src/lint/nursery/use_consistent_type_definitions.rs Outdated Show resolved Hide resolved

jakeleventhal and others added 4 commits July 31, 2025 09:29

Update .changeset/use-consistent-type-definitions.md

6dfd6f4

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>

Updating doc

5879bf7

use lcurly

e69dc7e

Merge commit '2e746485f0571b88f594becd9843e34f948c74d0' into typescri…

d08a068

…pt-eslint-consistent-type-definitions

jakeleventhal requested a review from ematipico August 1, 2025 11:09

Merge branch 'main' into typescript-eslint-consistent-type-definitions

dde0d9e

Adding more tests for comments

2645a42

ematipico approved these changes Aug 2, 2025

View reviewed changes

dyc3 approved these changes Aug 2, 2025

View reviewed changes

Merge branch 'main' into typescript-eslint-consistent-type-definitions

6d2dc2b

arendjr approved these changes Aug 5, 2025

View reviewed changes

.changeset/use-consistent-type-definitions.md Outdated Show resolved Hide resolved

Update .changeset/use-consistent-type-definitions.md

30f7b5c

arendjr merged commit 655049e into biomejs:main Aug 5, 2025
2 checks passed

github-actions bot mentioned this pull request Aug 4, 2025

ci: release #7069

Merged

renovate bot mentioned this pull request Aug 14, 2025

Update dependency biomejs/biome to v2.2.5 sugarshin/sugarshin.net#407

Open

1 task

Uh oh!

feat(analyze/js): added rule for @typescript-eslint/consistent-type-definitions #7053

feat(analyze/js): added rule for @typescript-eslint/consistent-type-definitions #7053

Uh oh!

Conversation

jakeleventhal commented Jul 28, 2025

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

dyc3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakeleventhal commented Jul 28, 2025

Uh oh!

dyc3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codspeed-hq bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #7053 will not alter performance

Summary

Uh oh!

dyc3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dyc3 left a comment

Choose a reason for hiding this comment

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ematipico commented Aug 1, 2025

Uh oh!

jakeleventhal commented Aug 1, 2025

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat(analyze/js): added rule for `@typescript-eslint/consistent-type-definitions` #7053

feat(analyze/js): added rule for `@typescript-eslint/consistent-type-definitions` #7053

changeset-bot bot commented Jul 28, 2025 •

edited

Loading

codspeed-hq bot commented Jul 29, 2025 •

edited

Loading