refactor(format): use specialised tokens #7052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
4a9f3fa to
d161316
Compare
CodSpeed Performance ReportMerging #7052 will not alter performanceComparing Summary
Footnotes |
d161316 to
48e43b3
Compare
dyc3
requested changes
Jul 28, 2025
crates/biome_html_formatter/src/html/auxiliary/self_closing_element.rs
Outdated
Show resolved
Hide resolved
48e43b3 to
c662a38
Compare
c662a38 to
7676748
Compare
dyc3
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors how the formatter formats trivias. Up until now, all sorts of trivia were formatted using generic functions such as:
format_replaced,format_removed,format_skipped_token_trivia, etc.These functions, however, have a shared logic that can't be overridden by specialised formatters.
In this PR, we introduce a trait called
FormatToken, which exposes functions such asformat_replacedand more. Those functions, now, must be implemented within the language formatters, which means thatbiome_formatterno longer knows how to do that.This refactor has some small repercussions on the separated lists, where now we need to pass generic functions
on_skippedandon_removed, because the generic formatter doesn't know how to print their trivia anymore.With this change, we can implement a specialised version of
fmt_skippedthat doesn't rely on the nestle logic: #5356Test Plan
The current CI should stay all green
Docs