feat(json/analyze): rule noQuickfixBiome
#6992
Conversation
🦋 Changeset detectedLatest commit: 61ae40d The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #6992 will degrade performances by 8.9%Comparing Summary
Benchmarks breakdown
Footnotes |
There was a problem hiding this comment.
I think we can initially promote to the correctness group as it's clear using quickfix.biome are mostly unintended.
There was a problem hiding this comment.
I thought about it, but I didn't want to wait for v2.2. And we can still promote it to v2.2 even though we have it in nursery now. While in nursery, we can ship it in patches and test it in real-world projects. What do you think?
8d73a0e to
2dfa40b
Compare
2dfa40b to
61ae40d
Compare
Co-authored-by: siketyan <12772118+siketyan@users.noreply.github.com>
Co-authored-by: siketyan <12772118+siketyan@users.noreply.github.com>
Summary
This PR adds a new rule called
noQuickfixBiomeand bans the use ofquickfix.biomein specific files: mainly VSCode and Zed settings.The use of
quickfix.biomeis deprecated and should be removed, which is why I created this rule.Test Plan
Added new tests
Docs
Added