+
Skip to content

refactor: add no-nested-component-definitions rule to eslint migration #6941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2025
Merged

refactor: add no-nested-component-definitions rule to eslint migration #6941

merged 3 commits into from
Jul 19, 2025

Conversation

JamBalaya56562
Copy link
Contributor

@JamBalaya56562 JamBalaya56562 commented Jul 19, 2025 •
edited
Loading

Summary

Add the ESLint React no-nested-component-definitions rule across migration and lint rule declaration

Enhancements:

  • Update migration mapping key to @eslint-react/no-nested-component-definitions
  • Adjust lint rule source identifier to no-nested-component-definitions

Why?

#990 renamed no-nested-components rule to no-nested-component-definitions and updated related docs.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: fb983b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jul 19, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 19, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #6941 will not alter performance

Comparing JamBalaya56562:no-nested (fb983b0) with main (e6b2380)1

Summary

✅ 115 untouched benchmarks

Footnotes

  1. No successful run was found on main (942048b) during the generation of this report, so e6b2380 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

dyc3
dyc3 reviewed Jul 19, 2025
View reviewed changes
crates/biome_js_analyze/src/lint/nursery/no_nested_component_definitions.rs Outdated
name: "noNestedComponentDefinitions",
language: "jsx",
sources: &[RuleSource::EslintReactXyz("no-nested-components").same()],
sources: &[RuleSource::EslintReactXyz("no-nested-component-definitions").same()],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to keep the old name around too, in case users are migrating from a version that uses the previous name.

Copy link
Contributor Author

@JamBalaya56562 JamBalaya56562 Jul 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I updated to use both old and new one.

version: "2.0.0",
        name: "noNestedComponentDefinitions",
        language: "jsx",
-       sources: &[RuleSource::EslintReactXyz("no-nested-components").same()],
+       sources: &[
+            RuleSource::EslintReactXyz("no-nested-components").same(),
+            RuleSource::EslintReactXyz("no-nested-component-definitions").same(),
+       ],
        recommended: false,
        domains: &[RuleDomain::React],
        severity: Severity::Error,

@JamBalaya56562 JamBalaya56562 force-pushed the no-nested branch 3 times, most recently from 4cb04a0 to 6d56c25 Compare July 19, 2025 12:49
@ematipico
Copy link
Member

ematipico commented Jul 19, 2025 •
edited
Loading

@JamBalaya56562 you need to run just gen-bindings and commit the changed files.

Also, I believe it would be useful to create a changeset, because we fixed the docs and the migration :)

@JamBalaya56562 JamBalaya56562 changed the title refactor: rename no-nested-components rule refactor: add no-nested-component-definition rule to eslint migration Jul 19, 2025
@JamBalaya56562 JamBalaya56562 changed the title refactor: add no-nested-component-definition rule to eslint migration refactor: add no-nested-component-definitions rule to eslint migration Jul 19, 2025
@JamBalaya56562
Copy link
Contributor Author

@JamBalaya56562 you need to run just gen-bindings and commit the changed files.

Also, I believe it would be useful to create a changeset, because we fixed the docs and the migration :)

Thank you so much!
I have run just gen-bindings and just gen-migrate so CI will pass.
Moreover, I added the new changeset.

ematipico
ematipico approved these changes Jul 19, 2025
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 😊

siketyan
siketyan approved these changes Jul 19, 2025
View reviewed changes
Copy link
Member

@siketyan siketyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JamBalaya56562 @siketyan
chore: update .changeset/breezy-spiders-flash.md
32844ad 
Co-authored-by: Naoki Ikeguchi <me@s6n.jp>
dyc3
dyc3 approved these changes Jul 19, 2025
View reviewed changes
@JamBalaya56562 @dyc3
chore: update .changeset/breezy-spiders-flash.md
fb983b0 
Co-authored-by: Carson McManus <dyc3@users.noreply.github.com>
@dyc3 dyc3 merged commit 734d708 into biomejs:main Jul 19, 2025
29 checks passed
@github-actions github-actions bot mentioned this pull request Jul 19, 2025
Merged
@JamBalaya56562 JamBalaya56562 deleted the no-nested branch July 19, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

@dyc3 dyc3 dyc3 approved these changes

@siketyan siketyan siketyan approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JamBalaya56562 @ematipico @dyc3 @siketyan
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载