+
Skip to content

fix: typo perfer-for → prefer-for #6947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2025
Merged

fix: typo perfer-for → prefer-for #6947

merged 2 commits into from
Jul 20, 2025
+7 −2

Conversation

JamBalaya56562
Copy link
Contributor

Summary

Fix typo in Solid.js ESLint rule name from “perfer-for” to “prefer-for” and add a corresponding changeset

Bug Fixes:

  • Correct rule key in migrate_eslint_any_rule from “solidjs/perfer-for” to “solidjs/prefer-for”
  • Update lint rule declaration to reference “prefer-for” instead of misspelled “perfer-for”

Chores:

  • Add changeset entry for the ESLint plugin fix

Test Plan

Before After
https://github.com/solidjs-community/eslint-plugin-solid/blob/main/packages/eslint-plugin-solid/docs/perfer-for.md https://github.com/solidjs-community/eslint-plugin-solid/blob/main/packages/eslint-plugin-solid/docs/prefer-for.md

Docs

eslint-plugin-solid

@github-actions github-actions bot added A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jul 19, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 19, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #6947 will not alter performance

Comparing JamBalaya56562:prefer-for (a105516) with main (734d708)

Summary

✅ 115 untouched benchmarks

dyc3
dyc3 approved these changes Jul 19, 2025
View reviewed changes
Copy link
Contributor

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@JamBalaya56562 @dyc3
chore: update .changeset/eleven-years-act.md
a105516 
Co-authored-by: Carson McManus <dyc3@users.noreply.github.com>
@dyc3 dyc3 merged commit 4c7ed0f into biomejs:main Jul 20, 2025
29 checks passed
@github-actions github-actions bot mentioned this pull request Jul 19, 2025
Merged
@JamBalaya56562 JamBalaya56562 deleted the prefer-for branch July 20, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

@dyc3 dyc3 dyc3 approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JamBalaya56562 @ematipico @dyc3
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载