fix(biome_js_analyze): ignore as const and similar wrappers in noMagicNumbers rule
#6944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b09016a The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
as const and similar wrappers in noMagicNumbers rule.
as const and similar wrappers in noMagicNumbers rule.as const and similar wrappers in noMagicNumbers rule
CodSpeed Performance ReportMerging #6944 will not alter performanceComparing Summary
Footnotes |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6910.
biome now ignores type casts and assertions when evaluating numbers for
noMagicNumbersrule.Test Plan
Updated
validsnapshot test with constant definitions that are supposed to be correct.Docs
Bugfix to a nursery rule - n/a.