-
-
Notifications
You must be signed in to change notification settings - Fork 644
feat(wasm): expose new functions #6896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 3f9ae0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4ca1db7
to
ca5ecc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
84b149f
to
303ecce
Compare
CodSpeed Performance ReportMerging #6896 will degrade performances by 61.19%Comparing 🎉 Hooray!
|
Benchmark | BASE |
HEAD |
Change | |
---|---|---|---|---|
❌ | js_analyzer[index_3894593175024091846.js] |
49.4 ms | 53.1 ms | -6.97% |
❌ | js_analyzer[parser_13571644119461115204.ts] |
79.4 ms | 85.6 ms | -7.26% |
🆕 | module_graph[@next/font/google/index.d.ts] |
N/A | 290.7 ms | N/A |
⚡ | deserialize_from_json_str[package.json] |
1,038.3 µs | 930.8 µs | +11.55% |
❌ | deserialize_from_json_str[tsconfig.json] |
218 µs | 561.8 µs | -61.19% |
@@ -537,7 +537,7 @@ impl TraversalContext for TraversalOptions<'_, '_> { | |||
// Note that `symlink/subdir` is not an existing file. | |||
let can_handle = !self | |||
.workspace | |||
.is_path_ignored(IsPathIgnoredParams { | |||
.is_path_ignored(PathIsIgnoredParams { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to rename this type because the initial I
was in conflict with the WASM types, which all start with I
Summary
This PR exposes new functions to the WASM distribution. It also creates new functions that allow to update and pull the module graph.
The new functions will be very useful for the playground, because at the moment project rules don't work. With the new functions, we will be able to that (for the most part). We still need some functions for storing the manifests.
Test Plan
Added new tests for the new functions. The CI should stay green
Docs