+
Skip to content

fix(biome_js_analyze): fixed noInvalidUseBeforeDeclaration false positives #6794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2025
Merged

fix(biome_js_analyze): fixed noInvalidUseBeforeDeclaration false positives #6794

merged 3 commits into from
Jul 12, 2025

Conversation

vladimir-ivanov
Copy link
Contributor

Summary

Fixed #6719: The noInvalidUseBeforeDeclaration false positives.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 68c49c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jul 8, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #6794 will improve performances by 9.85%

Comparing vladimir-ivanov:fix/no_invalid_use_before_declaration_add_more_cases (68c49c7) with main (f931570)

Summary

⚡ 1 improvements
✅ 113 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ eucjp_1600564308684076393.json[cached] 848.1 µs 772 µs +9.85%

@vladimir-ivanov
Copy link
Contributor Author

review please :-)

@dyc3
Copy link
Contributor

dyc3 commented Jul 8, 2025

I've noticed that your PR titles keep getting truncated. It's probably whatever tool you're using to create your PRs.

@vladimir-ivanov
Copy link
Contributor Author

I've noticed that your PR titles keep getting truncated. It's probably whatever tool you're using to create your PRs.

just GitHub.com - new pr from here.

e.g. pull requests link - new.
it seems to auto truncate. Can change manually re add the title next time?

@vladimir-ivanov vladimir-ivanov changed the title fix(biome_js_analyze): fixed noInvalidUseBeforeDeclaration false posi… fix(biome_js_analyze): fixed noInvalidUseBeforeDeclaration false positives Jul 9, 2025
@ematipico
Copy link
Member

Usually GitHub uses the first commit text as title, and if it's too long, it gets truncated

@dyc3
Copy link
Contributor

dyc3 commented Jul 10, 2025

Interesting. I use the GitHub CLI (not the web interface) to make PRs and don't have the truncating problem, even if my commit message is super long.

@vladimir-ivanov vladimir-ivanov merged commit 4d5fc0e into biomejs:main Jul 12, 2025
29 checks passed
@github-actions github-actions bot mentioned this pull request Jul 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unvalley unvalley unvalley approved these changes

Assignees
No one assigned
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💅 noInvalidUseBeforeDeclaration false positive
4 participants
@vladimir-ivanov @dyc3 @ematipico @unvalley
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载