fix(biome-js-analyze): fixed the diagnostic message for noFocusedTests to display the offending fn name #6599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 77a4a15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #6599 will not alter performanceComparing Summary
|
|
review please :-) |
dyc3
requested changes
Jun 27, 2025
crates/biome_js_analyze/src/lint/suspicious/no_focused_tests.rs
Outdated
Show resolved
Hide resolved
…s to display the offending fn name
5986ab1 to
84a741c
Compare
ematipico
approved these changes
Jun 28, 2025
.changeset/fix_no_focused_tests_diagnostic_message_to_have_correct_fn_name.md
Outdated
Show resolved
Hide resolved
.changeset/fix_no_focused_tests_diagnostic_message_to_have_correct_fn_name.md
Outdated
Show resolved
Hide resolved
dyc3
reviewed
Jun 28, 2025
crates/biome_js_analyze/src/lint/suspicious/no_focused_tests.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/tests/specs/suspicious/noFocusedTests/invalid.js.snap
Outdated
Show resolved
Hide resolved
…rect_fn_name.md Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
…rect_fn_name.md Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
…s to display the offending fn name
…s to display the offending fn name
…s to display the offending fn name
dyc3
approved these changes
Jun 29, 2025
Comment on lines
+10
to
+15
| Example for `fdescribe`: | ||
|
|
||
| ```diff | ||
| -│i The 'only' method is often used for debugging or during implementation. It should be removed before deploying to production. | ||
| +│i The fdescribe method is often used for debugging or during implementation. It should be removed before deploying to production. | ||
| ``` |
There was a problem hiding this comment.
changeset needs to be updated
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed #6380: The
noFocusedTestsrule now correctly displays the function name in the diagnostic message when a test is focused.Every instance of a focused test function (like
fdescribe,fit,ftest) had the word 'only' hardcoded.This has been updated to use the actual function name, so the message is now more accurate and specific.
Example for
fdescribe: