+
Skip to content

chore(justfile): adjust indentation and remove extra blank lines in justfile #6568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

paulo9mv
Copy link
Contributor

@paulo9mv paulo9mv commented Jun 26, 2025

Summary

This PR adjusts indentation and removes extra blank lines in the Justfile.
These changes improve the readability and maintainability of the build scripts without affecting any functionality. No related issues were found, and this is purely a code style cleanup.

Test Plan

  • Run just install-tools to ensure the script keeps working.

Copy link

changeset-bot bot commented Jun 26, 2025

⚠️ No Changeset found

Latest commit: b77db00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@paulo9mv paulo9mv changed the title chore: fix indentation and remove extra blank lines in justfile chore: adjust indentation and remove extra blank lines in justfile Jun 26, 2025
@paulo9mv paulo9mv changed the title chore: adjust indentation and remove extra blank lines in justfile chore(justfile): adjust indentation and remove extra blank lines in justfile Jun 26, 2025
@paulo9mv paulo9mv changed the title chore(justfile): adjust indentation and remove extra blank lines in justfile chore(justfile): adjust indentation and remove extra blank lines in justfile Jun 26, 2025
@paulo9mv paulo9mv changed the title chore(justfile): adjust indentation and remove extra blank lines in justfile chore(justfile): adjust indentation and remove extra blank lines in justfile Jun 26, 2025
@paulo9mv paulo9mv changed the title chore(justfile): adjust indentation and remove extra blank lines in justfile chore(justfile): adjust indentation and remove extra blank lines in justfile Jun 26, 2025
Copy link
Contributor

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kinda just feels like bikeshedding. I would be more open to merging it if it included a justfile formatter, so it could be enforced in CI.

@paulo9mv
Copy link
Contributor Author

@dyc3 Thanks for the feedback!
My intention was just to make a small adjustment, and I don’t plan to include a justfile formatter.
Feel free to close the PR if you think it’s not worth merging.

Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed it's bikeshedding, so if this becomes recurring I don't think we would accept these anymore.

But for now, since it's a one-time tiny improvement, let's have it :)

@arendjr arendjr requested a review from dyc3 June 27, 2025 07:31
@dyc3 dyc3 merged commit 659c305 into biomejs:main Jun 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载