feat(formatter): implement formatting for GritQL root node #4128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4128 will improve performances by 6.77%Comparing Summary
Benchmarks breakdown
|
ematipico
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements formatting for the GritQL root node. This helps to resolve the issue where the GritQL formatter trims the trailing newline, which caused the spec tests to panic. cc @branberry
Admittedly I'm not entirely sure why the default, verbatim node formatting strips the trailing newline. It creates some hard-to-debug behavior, so hopefully someone more familiar with our formatter infra has a suggestion how to resolve that.
Also added a
quick_test.rsfor the GritQL formatter, even though it didn't end up helping.Test Plan
Test added.