+
Skip to content

Conversation

blaze-d83
Copy link
Contributor

@blaze-d83 blaze-d83 commented Sep 25, 2024

Summary

Resolving issue #4076 highlighted by @nstepien

  • I was able to pinpoint where the format originated from.
  • Added the missing space() which should implement the desired format

@github-actions github-actions bot added A-Formatter Area: formatter L-CSS Language: CSS A-Changelog Area: changelog labels Sep 25, 2024
@blaze-d83 blaze-d83 changed the title Query feature range interval format fix: Query feature range interval format Sep 25, 2024
@blaze-d83 blaze-d83 changed the title fix: Query feature range interval format fix: updated query feature range interval format Sep 25, 2024
Copy link

codspeed-hq bot commented Sep 25, 2024

CodSpeed Performance Report

Merging #4083 will degrade performances by 24.06%

Comparing blaze-d83:query-feature-range-interval-format (35b9135) with main (75b4387)

Summary

❌ 1 regressions
✅ 106 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main blaze-d83:query-feature-range-interval-format Change
big5-added_15586211152145260264.json[uncached] 546.8 µs 719.9 µs -24.06%

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test? Plus some snapshots changed, so you need to run the test suite and accept the new snapshots

@blaze-d83
Copy link
Contributor Author

@ematipico

Hey hi!

Can you help me with this?

image

I tried to run test for the biome_css_formatter crate, but there this issue which wont let me do it.

Thanks!

@dyc3
Copy link
Contributor

dyc3 commented Sep 26, 2024

@blaze-d83 Try cargo clean first to clear the build cache.

@blaze-d83
Copy link
Contributor Author

@blaze-d83 Try cargo clean first to clear the build cache.

Yup. Tried that too. Still doesnt work.

I wonder if any thing is wrong with my approach:

  1. I created query_interval_test.css file with the following:
.class {
	@media (1024px <= width <= 1280px) {
		color: red;
	}
}
  1. Planning to run test for the crate biome_css_formatter

  2. Review and accept the snap.

Thanks in advance

@dyc3 dyc3 merged commit 44c455d into biomejs:main Sep 27, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Changelog Area: changelog A-Formatter Area: formatter L-CSS Language: CSS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载