feat(lsp): noExcessiveCognitiveComplexity diagnostic shows levels
#4028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4028 will improve performances by 10.41%Comparing Summary
Benchmarks breakdown
|
|
Fixed formatting and updated all tests for |
Conaclos
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Please refactor this function to reduce its complexity score from 17 to the max allowed complexity 15.Excessive complexity detected. (biome: lint/complexity/noExcessiveCognitiveComplexity)see: #4012
This PR simply inserts the levels in the diagnostic message to fix that.
I haven't touched any rust code before, but the change seems straightforward enough, though.