+
Skip to content

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 20, 2024

Summary

According to the spec, pretty much every character is allowed inside quotes.

https://html.spec.whatwg.org/#attribute-value-(double-quoted)-state

Test Plan

Added a test

@github-actions github-actions bot added A-Parser Area: parser L-HTML Language: HTML labels Sep 20, 2024
@dyc3 dyc3 force-pushed the 09-20-fix_parser_html_allow_multi_line_attribute_values branch from ca594d1 to 56a3c2d Compare September 20, 2024 21:28
@dyc3 dyc3 requested review from a team September 20, 2024 21:28
@dyc3 dyc3 marked this pull request as ready for review September 20, 2024 21:34
Copy link

codspeed-hq bot commented Sep 20, 2024

CodSpeed Performance Report

Merging #4018 will not alter performance

Comparing 09-20-fix_parser_html_allow_multi_line_attribute_values (56a3c2d) with main (b76cb41)

Summary

✅ 107 untouched benchmarks

@dyc3 dyc3 merged commit 29266a0 into main Sep 21, 2024
16 checks passed
@dyc3 dyc3 deleted the 09-20-fix_parser_html_allow_multi_line_attribute_values branch September 21, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Parser Area: parser L-HTML Language: HTML

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载