+
Skip to content

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 20, 2024

Summary

This PR implements resolving formatter options for HTML.

Test Plan

Tested manually on a local version of the playground. Planning to add tests. I couldn't find an easy way to add snapshot tests for this.

@github-actions github-actions bot added A-Project Area: project A-Formatter Area: formatter L-HTML Language: HTML labels Sep 20, 2024
@dyc3 dyc3 marked this pull request as ready for review September 20, 2024 20:20
@dyc3 dyc3 requested review from a team September 20, 2024 20:24
Copy link

codspeed-hq bot commented Sep 20, 2024

CodSpeed Performance Report

Merging #4017 will improve performances by 9.11%

Comparing 09-18-feat_html_resolve_format_options (1688110) with main (83626d9)

Summary

⚡ 2 improvements
✅ 105 untouched benchmarks

Benchmarks breakdown

Benchmark main 09-18-feat_html_resolve_format_options Change
dojo_11880045762646467684.js[cached] 8.4 ms 7.9 ms +6.06%
db_17847247775464589309.json[cached] 13.9 ms 12.8 ms +9.11%

@dyc3 dyc3 merged commit b3724b2 into main Sep 22, 2024
16 checks passed
@dyc3 dyc3 deleted the 09-18-feat_html_resolve_format_options branch September 22, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Formatter Area: formatter A-Project Area: project L-HTML Language: HTML

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载