chore: enforce usage of to_ascii_lowercase_cow #4014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arendjr
approved these changes
Sep 20, 2024
CodSpeed Performance ReportMerging #4014 will improve performances by 9.06%Comparing Summary
Benchmarks breakdown
|
Conaclos
approved these changes
Sep 20, 2024
dyc3
approved these changes
Sep 20, 2024
|
Whoops, I didn't see the check deps job failure. Fixed in #4016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Basically the same ideas as oxc-project/oxc#5586.
Enforce usage of
biome_string_case::StrExtension::to_ascii_lowercase_cowwith Clippy to minimize memory allocation.Test Plan
All existing tests should pass.