Handle a case where finishreason is not STOP and content is None #1498
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryL27
approved these changes
Oct 14, 2025
lib/sycamore/sycamore/llms/gemini.py
Outdated
| if response.candidates[0].content is None: | ||
| import json | ||
| logger.info(f"Gemini model returned no content: {json.dumps(response.model_dump(), indent=4)}") | ||
| output = "_NO_VALUE_" |
There was a problem hiding this comment.
Trying to parse the output as json won't kill this yes? I guess it's dead anyway
There was a problem hiding this comment.
Sorry, I think I will change this to an empty string. This was for debugging. I had trouble with an empty string in the log.
|
3 Jobs Failed: Testing / integ-tests (3.10) failed on "Unknown Step"Logs not found. Testing / notebook-tests-docprep (3.10) failed on "Unknown Step"Logs not found. Testing / notebook-tests-slow (3.10) failed on "Unknown Step"Logs not found. Summary: 4 successful workflows, 1 failed workflow
Last updated: 2025-10-15 06:03:31 UTC |
I need to handle this case, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.