-
Notifications
You must be signed in to change notification settings - Fork 65
Change ArynWriter
to use new serialization approach
#1384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
034c595
Add `web_serialize`
MarkLindblad a1c9448
Change `.aryn.write(...)` to use `web_serialize` instead
MarkLindblad d1070ff
Add `@experimental` decorators to web serialization methods
MarkLindblad 9f9a8cc
Fix mypy linting
MarkLindblad b570ad7
Fix black linting
MarkLindblad 9c9e348
Switch to using `msgpack`
MarkLindblad 5bf5795
Make more concise
MarkLindblad c9c1173
Fix ruff, black linting
MarkLindblad 1439d08
Make `web_deserialize` more forward-compatible
MarkLindblad 8fc848f
Mark web serialization as experimental, only allow serialization of b…
MarkLindblad 185be6a
Merge branch 'main' into mark/serialize
MarkLindblad 7ed3812
Avoid double `type` call
MarkLindblad 2055406
Fix linting
MarkLindblad 47031fe
Remove enuemeration left in
MarkLindblad 49f413d
Add magic bytes, version header, and zero padding
MarkLindblad a9227c4
Move helper functions to file scope
MarkLindblad 99094e0
Change to use `aryn_element_type` instead of `_kind`
MarkLindblad c522165
Switch to streaming approach, add tests
MarkLindblad 29f1c50
Switch warning message from `logging` to `warnings`
MarkLindblad eac53a0
Merge branch 'main' into mark/serialize
MarkLindblad 202fc28
Change usage of `struct`
MarkLindblad c4ec0d3
Add terminator to end of web_serialized documents, add test, fix `tes…
MarkLindblad eb450e5
Make use of more compact `struct.pack` representation
MarkLindblad 8c629ca
Rename `aryn_element_type` to `_aryn_element_type`
MarkLindblad d8845b5
Change `ValueError` to `RuntimeError` on Element web_serializization …
MarkLindblad a3f71d9
Rename `file` to `stream`
MarkLindblad ab96317
Remove unused `_reconstruct`
MarkLindblad 18e9ce5
Fix ruff linting
MarkLindblad febf289
Make `"!8s2H4x"` a global variable
MarkLindblad 342832e
Rename web serialization global variables
MarkLindblad c5759a1
Change unexpected end of file error message and type
MarkLindblad b226842
Fix message checked in unit test for unexpected end of stream
MarkLindblad e90cd74
Rename confusing variable named `read` to `got`
MarkLindblad 88a30d2
Change `if len(to_add) == 0:` to `if not to_add:`
MarkLindblad 01c619d
Change `readmin` to `read_header`
MarkLindblad 99a1102
Raise error on bad header earlier
MarkLindblad ac7f1d1
Change error message on bad magic number
MarkLindblad 051f89d
Remove dead code
MarkLindblad 1d6a8c7
Change web serialization errors from ValueErrors to RuntimeErrors
MarkLindblad 662cf08
Fix black linting
MarkLindblad 4ea302e
Fix error type checked for in web serialization unit tests
MarkLindblad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.