Add support for a custom supplement_text function in the partitioner. #1332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes additional customization possible that is otherwise difficult.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a custom supplement_text function in the partitioner, allowing users to override the default text-supplementation behavior.
- Updated the type imports to include Callable.
- Introduced a new parameter, supplement_text_fn, in the process_batch function signature.
- Replaced the direct call to self._supplement_text with the new supplement_text_fn call, preserving existing behavior via a default.
Comments suppressed due to low confidence (1)
lib/sycamore/sycamore/transforms/detr_partitioner.py:449
- Consider adding a docstring or inline comment for the supplement_text_fn parameter to clarify its purpose, expected inputs, and behavior.
supplement_text_fn: Callable[[list[Element], list[Element]], list[Element]] = _supplement_text,
karanataryn
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes additional customization possible that is otherwise difficult.
This change should have no impact on current behavior.