Add Ability to Resolve Boundary Overlaps in Tables #1337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to resolve boundary overlaps in tables by introducing a new boolean parameter and a dedicated function to adjust row and column boundaries. Key changes include:
- Adding the "resolve_overlaps" parameter to objects_to_table, refine_rows, refine_columns, and related functions.
- Implementing a new function to adjust overlapping boundaries for rows and columns.
- Propagating the new functionality through the table extraction process in the extract.py module.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/sycamore/sycamore/transforms/table_structure/table_transformers.py | Adds resolve_overlaps parameter, introduces resolve_overlaps() function, and updates refinement functions to optionally adjust overlaps. |
| lib/sycamore/sycamore/transforms/table_structure/extract.py | Updates the extract function to accept and pass along the resolve_overlaps flag. |
Comments suppressed due to low confidence (2)
lib/sycamore/sycamore/transforms/table_structure/table_transformers.py:213
- The boolean parameter 'resolve_overlaps' in 'refine_rows' conflicts with the function 'resolve_overlaps' defined in the module, causing a naming collision. Consider renaming the parameter (e.g., 'apply_overlap_resolution') or explicitly referencing the function to avoid shadowing.
if resolve_overlaps:
lib/sycamore/sycamore/transforms/table_structure/table_transformers.py:303
- The use of 'resolve_overlaps' as a boolean parameter in 'refine_columns' shadows the global function 'resolve_overlaps'. Renaming the parameter (e.g., 'apply_overlap_resolution') will help prevent unintended behavior.
if resolve_overlaps:
HenryL27
reviewed
Jun 10, 2025
lib/sycamore/sycamore/transforms/table_structure/table_transformers.py
Outdated
Show resolved
Hide resolved
HenryL27
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the necessary plumbing as well.