Sycamore: deal with rotated tables. #1336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsowell
reviewed
Jun 10, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR introduces utilities and modifications to better handle rotated tables in image documents. Key changes include:
- New rotation helper functions in rotation.py to support image and coordinate rotations.
- Enhancements in table structure extraction and text extraction, including handling of font size and additional vector data.
- Improved TableElement handling with a new shallow copy method and updated rotation logic in table extraction.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/sycamore/sycamore/utils/rotation.py | Introduces rotation utility functions for images, coordinates, and bounding boxes. |
| lib/sycamore/sycamore/transforms/text_extraction/text_extractor.py | Updates text extraction to incorporate font size and vector properties. |
| lib/sycamore/sycamore/transforms/table_structure/extract.py | Adds rotated_table and modifications to apply table rotation adjustments during extraction. |
| lib/sycamore/sycamore/transforms/detr_partitioner.py | Modifies token processing to include vector data and iterates page elements by index for in-place updates. |
| lib/sycamore/sycamore/data/element.py | Introduces a new shallow copy method for TableElement. |
bsowell
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.