Fix issue with nested_lookup utility. #1320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is used in some of the Jinja prompt formatters via Element::field_to_value. It previously assumed the object it was traversing was a dict and used the get method to look up values. In elements, this bypassed the @Property getters, which could lead to incorrect values. I observed the text_representation of a TableElement being null, because the value is set to the csv representation of the table in the getter.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with the nested_lookup utility by enabling proper attribute resolution via property getters.
- In lib/sycamore/sycamore/utils/nested.py, the lookup logic is updated to use getattr for objects that have properties.
- In lib/sycamore/sycamore/tests/unit/data/test_element.py, tests are added to validate the behavior for TableElement and its property-based text representation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/sycamore/sycamore/utils/nested.py | Updated nested_lookup to use attribute access for properties. |
| lib/sycamore/sycamore/tests/unit/data/test_element.py | Added unit tests for TableElement to validate field-to-value mapping. |
HenryL27
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is used in some of the Jinja prompt formatters via Element::field_to_value. It previously assumed the object it was traversing was a dict and used the get method to look up values. In elements, this bypassed the @Property getters, which could lead to incorrect values. I observed the text_representation of a TableElement being null, because the value is set to the csv representation of the table in the getter.