+
Skip to content

Conversation

akarshgupta7
Copy link
Contributor

No description provided.

@akarshgupta7 akarshgupta7 requested a review from baitsguy June 4, 2025 00:09
Copy link
Contributor

@baitsguy baitsguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to refactor this class. For now, I'd suggest at least renaming the 2nd return value to be something like "block_further_materialize" or something

@baitsguy
Copy link
Contributor

baitsguy commented Jun 4, 2025

Also add tests please

@akarshgupta7 akarshgupta7 merged commit 5d62674 into main Jun 4, 2025
12 of 15 checks passed
@akarshgupta7 akarshgupta7 deleted the akarsh/materialize-node branch June 4, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载