Enable pdfminer vertical text grouping. #1324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pdfminer has an option to support vertical text in its layout analysis. This commit simply enables that option, which correctly extracts vertical text.
There was a problem hiding this comment.
Pull Request Overview
This PR enables vertical text extraction support in pdfminer, ensuring that vertical text is correctly processed. Key changes include:
- Enabling detect_vertical in LAParams for pdfminer extraction.
- Adding a new unit test to verify vertical text extraction behavior.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/sycamore/sycamore/transforms/text_extraction/pdf_miner.py | Updated LAParams initialization to support vertical text grouping. |
| lib/sycamore/sycamore/tests/unit/transforms/test_detr_partitioner.py | Added tests verifying that vertical text is extracted correctly for both "lines" and "boxes" extractors. |
lib/sycamore/sycamore/tests/unit/transforms/test_detr_partitioner.py
Outdated
Show resolved
Hide resolved
karanataryn
approved these changes
May 30, 2025
|
|
||
| assert lines_text == objects_text | ||
|
|
||
| def test_pdfminer_vertical_text(self): |
There was a problem hiding this comment.
Can we split this into two tests? one for boxes and one for lines. It makes it easier to understand
There was a problem hiding this comment.
Sure. All the other pdfminer tests have both in one method, but I will split this one if you think it's clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pdfminer has an option to support vertical text in its layout analysis. This commit simply enables that option, which correctly extracts vertical text.