+
Skip to content

improve model selection error message #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

improve model selection error message #1311

merged 1 commit into from
May 22, 2025

Conversation

HenryL27
Copy link
Collaborator

previously:

ValueError("Invalid statement: 'default'. Did not find '->', so this is assumed to be a static statement, but the model_name was not in ('table_transformer', 'deformable_detr'))

Now:

ValueError("Bad model selection: default
Invalid statement: 'default'. Did not find '->', so this is assumed to be a static statement, but the model_name was not in ('table_transformer', 'deformable_detr'))

@HenryL27
improve model selection error message by including entire selection s…
d055dea 
…tring

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
@HenryL27 HenryL27 requested a review from austin-aryn-ai May 21, 2025 16:25
@austin-aryn-ai
Copy link
Contributor

How about:

Bad model selection: 'default'.  Valid values are ('table_transformer', 'deformable_detr')

Btw, are those values even documented? They sound way too technical...

@HenryL27
Copy link
Collaborator Author

HenryL27 commented May 21, 2025 •
edited
Loading

How about: ...

Issue is you can also do stuff like model_selection="chars > 1000 -> table_transformer; deformable_detr", so those aren't the only valid values. So e.g. you could get something like:

Bad model selection: chars > 1000 -> table_transformer; default
Invalid statement: 'default'. Did not find '->', so this is assumed to be a static statement, but the model_name was not in ('table_transformer', 'deformable_detr')

Documentation is here

@HenryL27 HenryL27 merged commit 77cafad into main May 22, 2025
11 of 15 checks passed
@HenryL27 HenryL27 deleted the hml-model-selection-messages branch May 22, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@austin-aryn-ai austin-aryn-ai austin-aryn-ai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HenryL27 @austin-aryn-ai
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载