Improve OpenSearch reader by batching certain operations #1267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The routine for fetching all child docs for a list of parent IDs had to make multiple calls to OpenSearch to get the count of child docs for each parent. This was done to ensure we don't do a paginated search that needs more than 10k results. To get around the 10k result limit of the
from
pagination, I changed to thescroll
pagination so this eliminated the need to make those calls to get doc counts.The fetching of parent docs is now done using
mget
instead ofget
.The doc reconstruct is also done in batches.