Reliability mocking bug #1160
Merged
Reliability mocking bug #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austintlee
approved these changes
Feb 7, 2025
austintlee
pushed a commit
that referenced
this pull request
Feb 7, 2025
austintlee
pushed a commit
that referenced
this pull request
Feb 14, 2025
* Ensure parent docs are collected during doc reconstruct * mock using patch (#1160) * Add a client for Aryn, use the new client to read docs * Use list_docs and get_doc for reading from Aryn * Mark Aryn classes experimental * Fix lint --------- Co-authored-by: Dhruv Kaliraman <112497058+dhruvkaliraman7@users.noreply.github.com>
austintlee
pushed a commit
that referenced
this pull request
Feb 14, 2025
* Ensure parent docs are collected during doc reconstruct * mock using patch (#1160) * Add a client for Aryn, use the new client to read docs * Use list_docs and get_doc for reading from Aryn * Mark Aryn classes experimental * Fix lint --------- Co-authored-by: Dhruv Kaliraman <112497058+dhruvkaliraman7@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using patch for mocking instead of modifying class method. Dunno why it took a day to show up in GH.