+
Skip to content

Conversation

austintlee
Copy link

No description provided.

Copy link
Contributor

@baitsguy baitsguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clean up the commented code before merging


logger.info(f"Parent IDs: {parent_ids}")
return pd.DataFrame([{"_source": {"doc_id": parent_id, "parent_id": parent_id}} for parent_id in parent_ids])
# logger.info(f"Parent IDs: {parent_ids}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you delete


os_client = client._client
records = OpenSearchReaderQueryResponse([doc], os_client)
# doc["_source"]["properties"] = json.loads(doc["_source"]["properties"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove


parent_doc = os_client.get(
index=self._query_params.index_name, id=doc_id
) # , _source_includes=["properties"])["_source"]["properties"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments

records = OpenSearchReaderQueryResponse([parent_doc], os_client)
docs = records.to_docs(query_params=self._query_params)

# properties[DocumentPropertyTypes.SOURCE] = DocumentSource.DOCUMENT_RECONSTRUCTION_PARENT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@austintlee austintlee merged commit 26156cc into main Feb 3, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载