Add OpenSearch shard related logging #1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 740a6e3.
austintlee
approved these changes
Jan 30, 2025
| response = super().search(**kwargs) | ||
| shards = response.get("_shards", {}) | ||
| if shards.get("total") != shards.get("successful"): | ||
| logger.error(f"OpenSearch query skipped shards: {response}") |
There was a problem hiding this comment.
It might be helpful to fish out "query" from kwargs (if it's present) and log it along with the response? Do you think we need to log the entire response payload? It could be big.
There was a problem hiding this comment.
I'll leave this in for now while we're debugging so we know which results actually got back. If it happens frequently enough and we handle it we can clean
HenryL27
reviewed
Jan 31, 2025
| import logging | ||
| from typing import Optional, Any | ||
|
|
||
| from opensearchpy import OpenSearch |
There was a problem hiding this comment.
here's the unconditional import
HenryL27
reviewed
Jan 31, 2025
|
|
||
| @requires_modules("opensearchpy", extra="opensearch") | ||
| def query(self, query: OpenSearchQuery) -> OpenSearchQueryResult: | ||
| from opensearchpy import OpenSearch |
There was a problem hiding this comment.
prob need to keep the import sycamore.connectors.opensearch.utils here instead of at the top
| llm: Optional[Union[LLM, str]] = None, | ||
| query_plan_strategy: Optional[QueryPlanStrategy] = None, | ||
| ): | ||
| from opensearchpy import OpenSearch |
| @classmethod | ||
| @requires_modules("opensearchpy", extra="opensearch") | ||
| def from_client_params(cls, params: BaseDBReader.ClientParams) -> "OpenSearchReaderClient": | ||
| from opensearchpy import OpenSearch |
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran locally and logged the opposite condition to make sure it's working