+
Skip to content

Conversation

Soeb-aryn
Copy link
Contributor

@Soeb-aryn Soeb-aryn commented Jan 23, 2025

Adding LLM request metrics, such as wall_latency, in_token, and out_token, to the docset metadata for each LLM call.

Copy link
Contributor

@baitsguy baitsguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we're repeating the same code a bunch of times, can you consolidate.

Also please add tests

@Soeb-aryn Soeb-aryn marked this pull request as ready for review January 27, 2025 19:05
Copy link
Contributor

@baitsguy baitsguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you add an assertion to an existing integ test too

@Soeb-aryn Soeb-aryn merged commit 088f4b6 into main Jan 28, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载