add groupby #1115
Closed
add groupby #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baitsguy
reviewed
Jan 17, 2025
| self._docset = docset | ||
| self._key = key | ||
|
|
||
| def aggregate(self, f) -> DocSet: |
There was a problem hiding this comment.
Should we consider subclassing DocSet or using a different type since most of our transforms aren't going to work with the new document structures? I think materialize on this won't work? @eric-anderson ?
HenryL27
reviewed
Jan 17, 2025
| self._docset = docset | ||
| self._key = key | ||
|
|
||
| def aggregate(self, f) -> DocSet: |
There was a problem hiding this comment.
yes, would add one
| dataset = self._docset.plan.execute().map(Document.from_row) | ||
| grouped = dataset.groupby(self._key) | ||
| aggregated = grouped.aggregate(f) | ||
| m = aggregated.take() |
There was a problem hiding this comment.
used for debug, would remove.
Comment on lines
+18
to
+24
| def to_doc(row: dict): | ||
| count = row.pop("count()") | ||
| doc = Document(row) | ||
| properties = doc.properties | ||
| properties["count"] = count | ||
| doc.properties = properties | ||
| return doc.to_row() |
There was a problem hiding this comment.
What's actually in a row at this point? These are ray ops, right?
Also why not just doc.properties['count'] = count?
| from sycamore.data import Document | ||
|
|
||
|
|
||
| class GroupedData: |
There was a problem hiding this comment.
Does this really belong in the transforms module? Might be a top-level thing.
There was a problem hiding this comment.
yes, might move it out.
baitsguy
approved these changes
Jan 23, 2025
|
merged in #1123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.