aryn-ai · dhruvkaliraman7 · Jan 7, 2025 · Jan 7, 2025 · Jan 7, 2025 · Jan 7, 2025
diff --git a/lib/sycamore/sycamore/tests/unit/utils/test_similarity.py b/lib/sycamore/sycamore/tests/unit/utils/test_similarity.py
@@ -0,0 +1,13 @@
+import pytest
+from unittest.mock import Mock
+from sycamore.utils.similarity import make_element_sorter_fn
+
+
+def test_make_element_sorter_fn_no_similarity_query():
+    sorter_fn = make_element_sorter_fn("test_field", None, Mock())
+    assert sorter_fn({}) is None
+
+
+def test_make_element_sorter_fn_no_similarity_scorer():
+    with pytest.raises(AssertionError, match="Similarity sorting requires a scorer"):
+        make_element_sorter_fn("test_field", "query", None)
diff --git a/lib/sycamore/sycamore/utils/similarity.py b/lib/sycamore/sycamore/utils/similarity.py
@@ -3,12 +3,11 @@
 
 
 def make_element_sorter_fn(field: str, similarity_query: Optional[str], similarity_scorer: Optional[SimilarityScorer]):
-    assert not (
-        (similarity_query is None) ^ (similarity_scorer is None)
-    ), "set both or neither of similarity_query and similarity_scorer"
     if similarity_query is None:
         return lambda d: None
 
+    assert similarity_scorer is not None, "Similarity sorting requires a scorer"
+
     def f(doc):
         score_property_name = f"{field}_similarity_score"
         doc = similarity_scorer.generate_similarity_scores(