+
Skip to content

Conversation

HenryL27
Copy link
Collaborator

  1. For thresholding, if we would eliminate all rows or columns instead set the threshold to the max-confidence one minus epsilon
  2. For slot_into_containers, if a package is contained equally in two containers (usually this means that the package is fully contained in both), slot it into the smaller container.
  3. Use the biggest "table" class object, rather than the most confident.

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
@HenryL27 HenryL27 requested a review from bsowell December 16, 2024 19:20
Copy link
Contributor

@bsowell bsowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to eyeball this and say whether these changes will improve things, but I don't see any glaring issues, so lgtm.


def apply_class_thresholds_or_take_best(bboxes, labels, scores, class_names, class_thresholds, epsilon=0.05):
"""
Filter out bounding boxes whose confidence is belor the confidence threshold for its
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: belor -> below

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
@HenryL27 HenryL27 merged commit 7c3ad39 into hml-deformable-table-lock Dec 17, 2024
12 of 14 checks passed
@HenryL27 HenryL27 deleted the hml-table-ppfix2 branch December 17, 2024 18:47
HenryL27 added a commit that referenced this pull request Dec 18, 2024
* factor around deformable detr loading/lockfile management for use with deformable table extractor

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>

* remove unused global variable

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>

* move .to(device) iniside the lock

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>

* jitpick

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>

* set deformable table extractor choose_device detr=True

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>

* Misc table transformers post-processing (#1077)

* misc postprocessing tweaks

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>

* typo

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>

---------

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>

---------

Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载