when there's no table structure, take the token bbox for the cell bbox #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Lindeman <hmlindeman@yahoo.com>
bsowell
reviewed
Dec 6, 2024
Comment on lines
177
to
178
| element.properties["backup_tokens"] = tokens | ||
| element.properties["object"] = objects |
There was a problem hiding this comment.
Are these net new properties that we are adding to table elements? Are they something we really want to expose to sycamore users?
There was a problem hiding this comment.
I know we remove tokens in DocParse. Would we need to remove these props too?
There was a problem hiding this comment.
oh whoops, those are in from debugging. will drop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the codepath where we don't attach a bbox to the table cells