extract table properties prompt & bug fix #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohou-aryn
reviewed
Nov 25, 2024
| Parse the CSV table, check the image, and return a flattened JSON object representing the key-value pairs from the table. The extracted key-value pairs should be formatted as a JSON object. | ||
| Do not return nested objects; keep the dictionary only one level deep. The only valid value types are numbers, strings, None, and lists. | ||
| Use camelCase for the key names. | ||
| A table can have multiple or all null values for a key. In such cases, return a JSON object with the specified key set to null for all rows in the table. |
There was a problem hiding this comment.
Do we need to handle empty cell case specially? in the prompt we sent to the llm, I would expect if our table representation could indicate the difference.
There was a problem hiding this comment.
I tried without explicitly mentioning this, but it didn’t work. Adding this line ensures it works consistently.
bohou-aryn
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: