Add streaming support and tests for query-server. #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austintlee
approved these changes
Nov 19, 2024
eric-anderson
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our upcoming customer deployment, we need a REST server that will return query plans, results, and the set of retrieved docs used in a query. This PR adds this capability to the existing
query-serverapp.I have also added streaming responses using SSE, in order to support streaming back large result sets (and to ensure the query plan and status are streamed back to the client while the query is running). Streaming is enabled if
stream=truein the query request, otherwise, a non-streamed response is returned.I've added a unit test for the app as well.