Add modifier instance for tuple of modifiers #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heh, this completely broke things 😅 not-so-gentle-reminded we need a test suite. |
armanbilge
commented
Feb 19, 2023
Comment on lines
78
to
81
| private trait ModifierLowPriority: | ||
| given forFoldable[F[_], E <: fs2.dom.Node[F], G[_]: Foldable, A]( | ||
| using M: Modifier[F, E, A]): Modifier[F, E, G[A]] = | ||
| (ga, e) => ga.foldMapM(M.modify(_, e)).void |
There was a problem hiding this comment.
Unfortunately this is causing a lot of angst, because Tuple also has foldable instances. Sadly I wonder if I should remove it in favor of instances specifically for List and stuff.
Indeed, this is what caused the original bug when I attempted to implement this.
There was a problem hiding this comment.
Replaced with a List-specific instance.
There was a problem hiding this comment.
... and Option instance too :) hopefully those are the main ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes the existing machinery in
HtmlTagso that it can replicated more easily in userland e.g. to support:h/t @yurique