Cleanup syntax #164
Merged
Cleanup syntax #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Jan 24, 2023
Comment on lines
-100
to
-101
| extension [F[_], A, B](pipe: Pipe[F, A, B]) | ||
| def channel(using F: Concurrent[F]): Resource[F, Channel[F, A]] = |
There was a problem hiding this comment.
I can't remember what I thought this would be useful for. Anyway, I think most likely you want to convert a Stream to a Signal with hold*. Not a Channel :)
Comment on lines
+85
to
+86
| def zoom[B](lens: Lens[A, B])(using Functor[F]): SignallingRef[F, B] = | ||
| SignallingRef.lens[F, A, B](sigRef)(lens.get(_), a => b => lens.replace(b)(a)) |
There was a problem hiding this comment.
This seems useful, right? 😅
2chilled
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.