ff-macros: reject zero unroll factor in unroll_for_loops #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the unroll_for_loops attribute accepted 0 as a valid integer because syn parses it as Lit::Int and we converted it to usize without additional checks. While negatives were already impossible (they parse as a unary minus over an int and are rejected), zero slipped through. This led to generated code in unroll.rs performing division and modulo by the unroll factor, causing a guaranteed runtime panic when unroll_by == 0.
This change adds an explicit guard in ff-macros/src/lib.rs to reject unroll_by == 0 with the same ARG_MSG (“must be a positive integer”), enforcing the documented constraint and converting a runtime panic into a compile-time error. No API changes; existing valid usages (e.g., 6, 12) are unaffected.