+
Skip to content

Conversation

ItzNotABug
Copy link
Member

@ItzNotABug ItzNotABug commented Oct 3, 2025

What does this PR do?

Fixes layout flex on columns page.

Test Plan

Manual.

Before -

Screenshot 2025-10-03 at 8 00 51 PM

After -
Screenshot 2025-10-03 at 8 00 21 PM

Related PRs and Issues

N/A.

Have you read the Contributing Guidelines on issues?

Yes.

Summary by CodeRabbit

  • New Features
    • Column keys now display in full (no abbreviation), with smart truncation when space is limited.
  • Style
    • Improved layout and alignment of the column key area for better readability.
    • Enhanced overflow handling and responsive behavior to prevent wrapping and clipping.
    • More consistent spacing and positioning for icons, tooltips, and status badges.
  • Refactor
    • Simplified and consolidated the UI structure of the column key cell for a more compact, maintainable layout.

@ItzNotABug ItzNotABug self-assigned this Oct 3, 2025
Copy link
Contributor

coderabbitai bot commented Oct 3, 2025

Walkthrough

  • Removed import of formatName from '$lib/helpers/string'.
  • Refactored the column key cell layout: consolidated outer Layout.Stack with updated direction/align/justify and min-width; added inner stacks for key display and sizing (min-width:0; flex:1 1 auto) with truncation and overflow handling; adjusted sibling stack to compact, non-wrapping layout with similar sizing constraints.
  • Replaced formatName(column.key, 6) with direct column.key display and preserved array suffix logic (column.array ? '[]' : undefined).
  • Maintained conditional rendering for icons, encryption tooltip, and status badges within the new structure.
  • No exported/public entity changes.
  • Estimated review effort: High.

Suggested reviewers

  • HarshMN2345

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title Check ❓ Inconclusive The title “Fix: layout flex.” references a fix related to layout flex but is overly generic and does not specify which UI component or page was updated, making it unclear for teammates scanning the history. Please revise the title to clearly indicate the affected component or page, for example “Fix flex layout in column key cell on the Columns page.”
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-columns-name

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e549344 and b798a48.

📒 Files selected for processing (1)
  • src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/columns/+page.svelte (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-30T07:41:06.679Z
Learnt from: ItzNotABug
PR: appwrite/console#2425
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte:454-468
Timestamp: 2025-09-30T07:41:06.679Z
Learning: In `src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte`, the column suggestions API (console.suggestColumns) has a maximum limit of 7 columns returned, which aligns with the initial placeholder count of 7 in customColumns.

Applied to files:

  • src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/columns/+page.svelte
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: e2e

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HarshMN2345 HarshMN2345 self-requested a review October 3, 2025 17:28
@ItzNotABug ItzNotABug merged commit a02d4cd into main Oct 3, 2025
3 checks passed
@ItzNotABug ItzNotABug deleted the fix-columns-name branch October 3, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载