+
Skip to content

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Aug 8, 2025

Based on @moe-ad's comments in #2529

@PProfizi PProfizi requested a review from moe-ad August 8, 2025 07:43
@PProfizi PProfizi self-assigned this Aug 8, 2025
@PProfizi PProfizi added CI/CD Related to CI/CD deploy-pr-doc For deploying a PR's documentation labels Aug 8, 2025
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.12%. Comparing base (dfba54e) to head (a220722).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2536      +/-   ##
==========================================
- Coverage   84.19%   84.12%   -0.07%     
==========================================
  Files          91       91              
  Lines       10703    10703              
==========================================
- Hits         9011     9004       -7     
- Misses       1692     1699       +7     

@PProfizi
Copy link
Contributor Author

PProfizi commented Aug 8, 2025

@moe-ad it looks like it is still not triggered

@PProfizi
Copy link
Contributor Author

PProfizi commented Aug 8, 2025

Two points from looking at the documentation and some issues online:

  • it looks like a reusable workflow cannot be used as a target for a workflow_run trigger -> keeping ci as the target instead of docs. Also we do not want any manually run docs workflow to trigger a deployment.
  • it looks like the workflow with the workflow_run trigger has to be in the main/default branch. I am not sure if this means it has to simply exist there and it will still pick the version in the dev branch, or if it will always use the version in the default branch. -> one way to find out is to merge this PR and continue investigating.

@PProfizi PProfizi merged commit 9edb5f8 into main Aug 8, 2025
46 checks passed
@PProfizi PProfizi deleted the ci/fix_deploy_pr_doc_trigger branch August 8, 2025 08:48
@moe-ad
Copy link
Contributor

moe-ad commented Aug 8, 2025

I also came across issues where people have been confused about the workflow_run trigger, and concluded there is no way of understanding things unless we merge first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related to CI/CD deploy-pr-doc For deploying a PR's documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载