fix(plotter): merge fields of fields_container before plot #2414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2414 +/- ##
==========================================
- Coverage 84.19% 84.16% -0.03%
==========================================
Files 91 91
Lines 10597 10600 +3
==========================================
Hits 8922 8922
- Misses 1675 1678 +3 |
|
The documentation for this pull request will be available at https://dpf.docs.pyansys.com/pull/2414. Please allow some time for the documentation to be deployed. |
|
The documentation generated shows no difference with current one in example plots. |
rafacanton
approved these changes
Jul 8, 2025
|
This PR has been closed. Documentation for this pull request will shortly be removed from its former deployment address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
Plotter.add_fieldmethod overrides data for fields with overlapping scoping, we merge the fields inFieldsContainer.plot()before the call toadd_field.The previous plots for a FieldContainer with several meshes with the same support were wrong and only showed the data of the last field.