fix: custom type check for unsupported type #2407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafacanton
approved these changes
Jul 2, 2025
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2407 +/- ##
==========================================
- Coverage 84.19% 84.17% -0.03%
==========================================
Files 91 91
Lines 10593 10597 +4
==========================================
+ Hits 8919 8920 +1
- Misses 1674 1677 +3 |
|
The documentation for this pull request will be available at https://dpf.docs.pyansys.com/pull/2407. Please allow some time for the documentation to be deployed. |
|
This PR has been closed. Documentation for this pull request will shortly be removed from its former deployment address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2405 by raising an error at creation of a custom type entity (
CustomTypeFieldorDPFVectorCustomType) if the type is not convertible to actype.