feat(server): Add ServerContext.xml_path setter #2386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2386 +/- ##
===========================================
- Coverage 84.20% 46.98% -37.23%
===========================================
Files 91 91
Lines 10675 10679 +4
===========================================
- Hits 8989 5017 -3972
- Misses 1686 5662 +3976 |
|
The documentation for this pull request will be available at https://dpf.docs.pyansys.com/pull/2386. Please allow some time for the documentation to be deployed. |
…xml_path for a "dpf.AvailableServerContexts.custom_defined" context.
43cba7c to
ee29bd9
Compare
rafacanton
reviewed
Jul 4, 2025
PProfizi
commented
Jul 4, 2025
PProfizi
commented
Jul 4, 2025
PProfizi
commented
Jul 4, 2025
PProfizi
commented
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow setting the
xml_pathfor adpf.AvailableServerContexts.custom_definedcontext.First remark: the right
AvailableServerContextfor using a custom xml path isno_context(context_type=2) instead ofcustom_defined(context_type=3)... this is confusing.Second remark: despite the tests passing on my local machine with a unified Ansys install, it does not pass in the GH pipelines with a standalone DPF. Is there something I am missing?
@rafacanton @ansys-akarcher I think I will need some help on this one. This comes from a workaround shared to a client where they needed to remove
multiphysics_mapperfrom default plugins. It is easier for them to share a customXMLfile and use it within a PyDPF script rather than modifying their actual DPF installation.The workaround shared was to use
ServerContext(context_type=2, xml_path="path/to/file").The point here is to make this user-friendly.