+
Skip to content

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Jun 17, 2025

Answers part of #2009

Until now the locations enum has not been available in the API reference since it is defined in ansys/dpf/gate/common which is excluded from the API reference.

This is very problematic as we reference locations all the time in the rest of the doc but the Enum in itself turns out to be hidden.

@PProfizi PProfizi self-assigned this Jun 17, 2025
@PProfizi PProfizi added the bug Something isn't working label Jun 17, 2025
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.11%. Comparing base (eda944c) to head (8635134).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2375      +/-   ##
==========================================
+ Coverage   84.10%   84.11%   +0.01%     
==========================================
  Files          91       91              
  Lines       10529    10540      +11     
==========================================
+ Hits         8855     8866      +11     
  Misses       1674     1674              

Copy link
Contributor

The documentation for this pull request will be available at https://dpf.docs.pyansys.com/pull/2375. Please allow some time for the documentation to be deployed.

@PProfizi PProfizi force-pushed the fix/make_locations_part_of_publicly_documented_code branch from 4bc2713 to a560270 Compare June 17, 2025 10:14
@PProfizi PProfizi requested a review from a team as a code owner June 17, 2025 10:14
Copy link
Contributor

github-actions bot commented Jun 17, 2025

Some tests with 'continue-on-error: true' have failed:

  • PyDPF-Post docstring tests on ubuntu-latest

  • PyDPF-Post API tests on ubuntu-latest

  • PyDPF-Post docstring tests on windows-latest

  • PyDPF-Post API tests on windows-latest

    Created by continue-on-error-comment

@rafacanton
Copy link
Contributor

@PProfizi I approved but saw that post is broken, I guess that a PR is needed there following this one

@PProfizi PProfizi requested a review from a team June 17, 2025 13:06
@PProfizi
Copy link
Contributor Author

@PProfizi I approved but saw that post is broken, I guess that a PR is needed there following this one

Yes, I will adapt Post right away, thanks!

@PProfizi PProfizi merged commit fb1fd63 into master Jun 17, 2025
43 checks passed
@PProfizi PProfizi deleted the fix/make_locations_part_of_publicly_documented_code branch June 17, 2025 13:07
Copy link
Contributor

This PR has been closed. Documentation for this pull request will shortly be removed from its former deployment address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载