Support PropertyField location after server changes #2322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2322 +/- ##
=======================================
Coverage ? 84.07%
=======================================
Files ? 91
Lines ? 10701
Branches ? 0
=======================================
Hits ? 8997
Misses ? 1704
Partials ? 0 |
|
sync successful CI |
3a5d304 to
454ae04
Compare
cbellot000
reviewed
Aug 1, 2025
src/ansys/dpf/core/property_field.py
Outdated
| ) | ||
| self._field_definition_instance = None | ||
| if meets_version(self._server.version, "11.0"): | ||
| self._field_definition_instance = self._load_field_definition() |
There was a problem hiding this comment.
why doing it at init and not lazy anymore? It can have non negligeable impact on performance
There was a problem hiding this comment.
Yes, you are right, let's see if the tests are not impacted by this change. I was replicating the behavior of the Field, but you are right on the performance point.
| return field_grpcapi._get_stub(client).Create(request) | ||
|
|
||
| @staticmethod | ||
| def csproperty_field_new_location_on_client(client, numEntities, data_size, location): |
There was a problem hiding this comment.
why did we need a new API here, couldn't we do field_def_new and then set_location?
PProfizi
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adter the last server changes in v11, the
PropertyFieldlocation is defined on itsFieldDefinitionand it is independent from the location of itsScoping. Changes are made to the setters and getters to support this.