DpfVector BUG: DpfVector were created on one clayer and deleted in another #2141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2141 +/- ##
==========================================
+ Coverage 86.57% 86.66% +0.08%
==========================================
Files 90 90
Lines 10310 10303 -7
==========================================
+ Hits 8926 8929 +3
+ Misses 1384 1374 -10 🚀 New features to boost your workflow:
|
|
@cbellot000 could we maybe have a test to ensure behavior is fixed? |
We do have a test: it's the reason why #2135 is failing :) |
PProfizi
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on distributed workflows (in process and gRPC), DPFVector were sometimes created on one clayer and deleted on another. This prevented any changes in the DPFVector.