+
Skip to content

Pin aliases #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Mar 4, 2025
Merged

Pin aliases #2059

merged 31 commits into from
Mar 4, 2025

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Feb 7, 2025

This PR exposes APIs for pin name aliases in PyDPF-Core, along with a template update for operator module generation to enable retro-compatibility of scripts using aliases, as well as warning about deprecation of said aliases.

@PProfizi PProfizi added the enhancement New feature or request label Feb 7, 2025
@PProfizi PProfizi self-assigned this Feb 7, 2025
@PProfizi PProfizi requested a review from a team as a code owner February 7, 2025 17:30
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.34%. Comparing base (1579d2c) to head (c36b6e3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2059      +/-   ##
==========================================
- Coverage   86.48%   86.34%   -0.14%     
==========================================
  Files          90       90              
  Lines       10285    10300      +15     
==========================================
- Hits         8895     8894       -1     
- Misses       1390     1406      +16     

@PProfizi PProfizi force-pushed the feat/handle_pin_aliases branch 3 times, most recently from b0a557e to ee192a5 Compare February 10, 2025 14:42
@PProfizi
Copy link
Contributor Author

Here is an example of a server sync update with the current changes (plus a few others due to diff with master):
https://github.com/ansys/pydpf-core/pull/2067/files

@rafacanton
Copy link
Contributor

@PProfizi This looks nice, also the operator code update. Can we add a test to ensure that we get the warning when we try to connect op.inputs.ponderation? Of course, when we eliminate ponderation in the future, the test will crash and we just remove it.

@PProfizi
Copy link
Contributor Author

PProfizi commented Feb 26, 2025

@PProfizi This looks nice, also the operator code update. Can we add a test to ensure that we get the warning when we try to connect op.inputs.ponderation? Of course, when we eliminate ponderation in the future, the test will crash and we just remove it.

I'd actually like to merge this without having to wait for the PR server-side which does the switch of ponderation to an alias. -> merging this first ensures pipeline using pydpf-core's default branch will never be broken (or ARM tests, etc) during server-sync
I will add the test in a future PR. See #2117

@PProfizi PProfizi force-pushed the feat/handle_pin_aliases branch from 720e249 to 143aa6e Compare February 26, 2025 11:45
@PProfizi PProfizi force-pushed the feat/handle_pin_aliases branch from 106e8c0 to 42be3fd Compare March 4, 2025 13:50
@PProfizi PProfizi merged commit 362a2d1 into master Mar 4, 2025
46 checks passed
@PProfizi PProfizi deleted the feat/handle_pin_aliases branch March 4, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载